CFSPDK-1274: Added a wrapper to individually disable devices, then enter system suspend #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spend Signed-off-by: YHusain1 <[email protected]>
jvhutch
reviewed
May 6, 2023
| const struct device *tmo_dev_list[] = {DEVICE_DT_GET(DT_NODELABEL(rs9116w)), | ||
| DEVICE_DT_GET(DT_NODELABEL(sonycxd5605)), | ||
| DEVICE_DT_GET(DT_NODELABEL(murata_1sc))}; | ||
|
|
There was a problem hiding this comment.
Consider moving the device list within the two_pm_sys_lp_wrapper() scope.
jvhutch
reviewed
May 6, 2023
| const struct device *dev = NULL; | ||
| for (int i = 0; i < sizeof(tmo_dev_list) / sizeof(tmo_dev_list[0]); i++) { | ||
| dev = tmo_dev_list[i]; | ||
| pm_device_action_run(dev, PM_DEVICE_ACTION_SUSPEND); |
There was a problem hiding this comment.
We should check the exit status of calls to the power management functions--and respond accordingly.
jvhutch
reviewed
May 6, 2023
Comment on lines
+35
to
+38
| led_off(dev, 0); | ||
| led_off(dev, 1); | ||
| led_off(dev, 2); | ||
| led_off(dev, 3); |
There was a problem hiding this comment.
Rather than the hard-coded values, let's include the board.h file and use the macros defined therein.
YHusain1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
When issuing the
tmo sys_pm suspendor thetmo sys_pm standby, the system becomes completely unresponsive due to the murata and wifi driver's expecting an interruptible context during issuing their corresponding device specific low power commands to the chip, however the system is in an non-blockable state before entering the Zephyr's sys_pmpm_system_suspendfunction.After this commit,
We implement a workaround that is a wrapper function which individually suspends the wifi, modem, gnss, gnss_pwr, LEDs devices and then make the rest of the system and remaining devices go to sleep.